XEP-0363: Not sending headers with upload request
See original GitHub issueDescribe the bug Converse.js does not set the headers provided by the server with the upload. See ‘Requesting a Slot’ and example 6 to see what that looks like.
The
<put>
element MAY also contain a number of<header>
elements which correspond to HTTP header fields. Each<header>
element MUST have a name-attribute and a content with the value of the header. Only the following header names are allowed:Authorization
,Cookie
,Expires
. Other header names MUST be ignored by the requesting entity and MUST NOT be included in the HTTP request. The requesting entity MUST strip any newline characters from the header name and value before performing the HTTP request.
To Reproduce You can use mod_http_file_share in Prosody trunk, which now requires an Authorization header on uploads.
Currently Converse.js will receive a HTTP 401 status code when attempting the upload.
Additional context I’m happy to provide test accounts on a server requiring upload headers if needed.
Issue Analytics
- State:
- Created 2 years ago
- Comments:6 (3 by maintainers)
Top GitHub Comments
Yes, it’s been fixed on the master branch.
You can try out the latest code here: https://conversejs.org/trunk/fullscreen.html (notice the
trunk
in the URL).Soon™
This fix isn’t in Converse 8.0.1.
It will only be part of the next release, version 9.