question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Bug: canPlay is returning true for all facebook URLs

See original GitHub issue

Current Behavior

After the new update the canPlay function is returning true for all facebook URLs because of the new matcher. This results in a lot of false positives.

Expected Behavior

canPlay should only return true if it actually can be played.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:9 (4 by maintainers)

github_iconTop GitHub Comments

2reactions
sapkracommented, Feb 2, 2020

@CookPete I’ve improved it a bit to not match any facebook pages which include watch or video.

https://regexr.com/4tdur

1reaction
paulincaicommented, Feb 2, 2020

@CookPete I get it.

Not related to the present issue/task, the thing is that I use a scrapper for all web content that lands in my platform and the URL in #778, “https://www.facebook.com/watch/?v=499831560618548” ends up as “https://www.facebook.com/francknicolasofficiel/videos/499831560618548/” This is the “real” URL that ReactPlayer actually plays because the FB SDK returns this URL not the “watch” url.

And now I remember that I decided to rely on the scrapper for consistency of all URLs having them correctly formatted before saving to DB.

I am for @sapkra 's regex. I think it covers well.

Read more comments on GitHub >

github_iconTop Results From Across the Web

I can't view or play videos on Facebook. | Facebook Help Center
If you're having trouble playing videos on Facebook, here are some things you can try. · Restart your browser and computer: · Check...
Read more >
Meta Drops Forced Facebook Logins with Rollout of New ...
Update (August 23rd, 2022): Meta has begun the planned rollout of its Meta Account logins and Meta Horizon user profiles, which does away ......
Read more >
ReactPlayer - GitHub
A React component for playing a variety of URLs, including file paths, YouTube, Facebook, Twitch, SoundCloud, Streamable, Vimeo, Wistia and DailyMotion ...
Read more >
How to Find and Fix 404 Errors - Neil Patel
It doesn't matter if they mistyped the URL or the page no longer exists. ... Filter for Client Error 4XX to get a...
Read more >
Configuring links | React Navigation
Note: Currently there seems to be bug (facebook/react-native#25675) which results in it ... Here Chat is the name of the screen that handles...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found