Native player controls ignoring 'playing' prop

I want to use the native controls, but also pause the player with the playing prop. I have a few timestamps within my video and i want to jump to them and pause the player.

const playerRef = useRef<ReactPlayer>()
const [playing, setPlaying] = useState(false)

useEffect(() => {
  setPlaying(false)
  playerRef.current.seekTo(playhead, 'seconds')
},        [playhead]) // playhead is set on click on a timestamp

<ReactPlayer
  ref={playerRef}
  playing={playing}
  url={url}
  controls={true}
  />

Current Behavior

if the player is started from the native controls, it ignores the playing prop.

if i control the player only with the playing prop, everything is working

Expected Behavior

regardless of the type of controls i use, the video should play and pause according the playing prop.

Environment

• Browser: Version 78.0.3904.87
• Operating system: Fedora 31

[cdreier]

as i think the additional callbacks are more a workaround, read a bit through the code

in https://github.com/CookPete/react-player/blob/master/src/Player.js#L55 are checks for the prevProps.playing and if it toggled - but the native controls, does not change the props. Can we just remove the prevProps.playing checks?

if the new props want the player to pause, why not just pause?

[cdreier]

Alright, so thanks a lot for the discussion 😃

As we have a solution and will not change anything, I close this issue.

Best regards, Christian