[Bug] Training code's dependency on pyworld breaks TTS Windows pip installation
See original GitHub issueDescribe the bug
Environment: OS Name Microsoft Windows 10 Pro Version 10.0.19044 Build 19044 Python 3.9.13
Running pip install TTS
in Windows triggers a known build error for one of its dependencies:
The pyworld build error is fixable by installing correct MSVC toolset (Microsoft Visual C++ 14.0 or greater is required.) in https://visualstudio.microsoft.com/visual-cpp-build-tools/ but will lead to another link error possibly related to Cython version (similar issue: https://github.com/wxWidgets/Phoenix/pull/2017)
A cleaner way is to remove dependency on pyworld
for TTS pip installation. The pip installation option is for people who are only interested in synthesizing speech with the released 🐸TTS models, not for training the model. Correct me if wrong, there is no need to depend on pyworld
which is, as I understand, only for training the model.
To Reproduce
- Run the following command ‘pip install TTS’ in Windows
- See error
Expected behavior
No response
Logs
No response
Environment
{
"CUDA": {
"GPU": [],
"available": false,
"version": "11.3"
},
"Packages": {
"PyTorch_debug": false,
"PyTorch_version": "1.11.0+cu113",
"TTS": "0.7.1",
"numpy": "1.21.6"
},
"System": {
"OS": "Windows",
"architecture": [
"64bit",
"WindowsPE"
],
"processor": "Intel64 Family 6 Model 140 Stepping 1, GenuineIntel",
"python": "3.9.13",
"version": "10.0.19044"
}
}
Additional context
No response
Issue Analytics
- State:
- Created a year ago
- Comments:6 (3 by maintainers)
Top GitHub Comments
To get rid of this we can switch to pyin. It is slower but it works 😃.
Would you deal with that @Edresson?
This issue was solved with PR #1946 where we replaced the Pyworld with Librosa Pyin.