travis build for own 3rdparty cordapps is failing due to -sources.jar in classpath

while building a 3rdparty library and running testcases using cordapp Testnetworks the tests are crashing

version:

        corda_release_group = 'net.corda'
        corda_release_group_plugins = 'net.corda.plugins'
        corda_release_version = '4.1'
        corda_gradle_plugins_version = '4.0.42'

exception during tests

ch.cordalo.corda.common.flows.test.TestBaseFlowTests > testCreate FAILED
   java.lang.IllegalArgumentException: There is more than one CorDapp containing the package ch.cordalo.corda.common.contracts on the classpath 
[/home/travis/build/cordalo-ch/cordalo/corda-common/build/libs/corda-common-contracts-0.1-SNAPSHOT-javadoc.jar, 
/home/travis/build/cordalo-ch/cordalo/corda-common/build/libs/corda-common-contracts-0.1-SNAPSHOT.jar]. 
Specify a package name which is unique to the CorDapp.
       at net.corda.testing.node.internal.TestCordappImpl.getJarFile(TestCordappImpl.kt:34)

reproduce bug

• create a 3rd party library
• implement a test case and use MockNetwork with parameters network = new MockNetwork(new MockNetworkParameters(testCordapps));
• use standard ‘maven’ plugin and ‘signing’ plugin to upload at the end the artifacts to OSS

    apply plugin: 'maven'
    apply plugin: 'signing'

• build sources and javadoc as seperate .jars for OSS maven repo

     task javadocJar(type: Jar) {
        classifier = 'javadoc'
        from javadoc
    }
    task sourcesJar(type: Jar) {
        classifier = 'sources'
        from sourceSets.main.allSource
    }
    artifacts {
        // dont add javadocjars and source to it because travis is not able to build
        // archives javadocJar, sourcesJar
    }

issue if

• archives are built for javadocJar and sourcesJar

archives javadocJar, sourcesJar working if commented // archives javadocJar, sourcesJar

[cedricwalter]

Lost some time and was facing the same issue, till i found this fix. When will it will integrated in Corda 4.4+ ?

[lolo8304]

solution to be implemented in: TestCordappImpl.kt

• remove -sources.jar and -javadoc.jar patterns as -test.jar pattern below

Original

        private fun findRootPaths(scanPackage: String): Set<Path> {
            return packageToRootPaths.computeIfAbsent(scanPackage) {
                val classGraph = ClassGraph().whitelistPaths(scanPackage.replace('.', '/'))
                classGraph.pooledScan().use {
                    it.allResources
                            .asSequence()
                            .map { it.classpathElementFile.toPath() }
                            .filterNot { it.toString().endsWith("-tests.jar") }
                            .map { if (it.toString().endsWith(".jar")) it else findProjectRoot(it) }
                            .toSet()
                }
            }
        }

fixed

        private fun findRootPaths(scanPackage: String): Set<Path> {
            return packageToRootPaths.computeIfAbsent(scanPackage) {
                val classGraph = ClassGraph().whitelistPaths(scanPackage.replace('.', '/'))
                classGraph.pooledScan().use {
                    it.allResources
                            .asSequence()
                            .map { it.classpathElementFile.toPath() }
                            .filterNot { it.toString().endsWith("-tests.jar") }
                            .filterNot { it.toString().endsWith("-javadoc.jar") }
                            .filterNot { it.toString().endsWith("-sources.jar") }
                            .map { if (it.toString().endsWith(".jar")) it else findProjectRoot(it) }
                            .toSet()
                }
            }
        }