Rethink/rewrite rule 953120 for re2 support
See original GitHub issueMotivation
Proposed solution
The rule matches on the response body <\?(?!xml)
, looking to detect the presence of the PHP open tag “<?
” or “<?php
” in output.
Alternatives
Looking at PHP tags they can use <\?\s+
, <\?\=\s+
or <\?php\s+
for the starting tag.
I think we should change it to match exactly for that, like: <\?(?:\=|php)?\s+
.
Additional context
Issue Analytics
- State:
- Created 2 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
No results found
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Thanks. Updated PR and now is ready to be reviewed.
@lifeforms Can you take a look also to the linked PR?
I think that’s sensible, you shouldn’t need the chained rule anymore.