question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rethink/rewrite rule 953120 for re2 support

See original GitHub issue

Motivation

Proposed solution

The rule matches on the response body <\?(?!xml), looking to detect the presence of the PHP open tag “<?” or “<?php” in output.

Alternatives

Looking at PHP tags they can use <\?\s+, <\?\=\s+ or <\?php\s+ for the starting tag.

I think we should change it to match exactly for that, like: <\?(?:\=|php)?\s+.

Additional context

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
fzipicommented, Jan 21, 2022

Thanks. Updated PR and now is ready to be reviewed.

@lifeforms Can you take a look also to the linked PR?

0reactions
fgschcommented, Jan 21, 2022

I think that’s sensible, you shouldn’t need the chained rule anymore.

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found