question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Generalize `to_pyro_random_module` for other PPLs

See original GitHub issue

Please let me know if there is a better way to go about this 😃

A clear and concise description of what you wish to refactor. Please include the following:

We would like to generalize to_pyro_random_module in order for other PPLs (eg beanmachine) to integrate with gpytorch.

Modules that will be modified

Impact on code structure

  • largely (all except upstreaming the integration in the last bullet) cosmetic, no change in structure

Impact on speed

  • n/a

Will this be a breaking change?

  • Yes, both library BW compatibility due to renaming functions as well as binary compatibility due to renaming class names

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:2
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
Balandatcommented, Oct 11, 2022

My hot take is that people shouldn’t pickle but instead save state dicts.

1reaction
Balandatcommented, Oct 10, 2022

That makes sense to me. I think in regards to backwards compatibility, we could just keep the pyro_ versions of the functions as aliases to the newly introduced ones and raise DeprecationWarnings.

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found