Layout-Bug for TracingCard UI states resulting in not readable risk card/risk details fragment
See original GitHub issueAvoid duplicates
- Bug is not mentioned in the FAQ
- Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
- Bug is not already reported in another issue
Describe the bug
In the past days, CWA was fetching diagnosis keys from server in the background very soon after 0:00 UTC. Because the new DKs hadn’t been deployed yet at that point in time, CWA was checking with old data from the day before… But this is a seperate issue (#1691). To make sure to have a download of ‘fresh’ DKs, I deactivated Exposure Logging last night before sleep. In the morning, I opened CWA, navigated to the fragment that allows for enabling Exposure Logging, enabled logging again, and then immediately navigated back to the home screen. Instead of a risk card showing “Daten werden heruntergeladen…” there was only a blank/white risk card. Tapping and holding the risk card switched the background of the card to light grey, and a white text “Daten werden heruntergeladen…” was visible. After releasing the finger, CWA switched to risk details screen, showing only a blank/white screen. Navigating back to the main screen showed again a white risk card. After the download was finished, the risk card updated automatically to a green card with white text “Prüfung…” (shouldn’t the background be dark grey either?). After the DKs had been provided to ENF, the risk card updated automatically to the green card “Low Risk”. I guess, the background color was not set correctly, while the (white) text was visible. I made some screenshots… see below.
Expected behaviour
The risk card “Daten werden heruntergeladen…” and the risk details fragment should have a dark grey background, like seen in @d4rken 's screenshots #1486 . According to #1486 , the risk card should probably also have a dark grey background while “Prüfing läuft…”.
Steps to reproduce the issue
- Deactivate Exposure Logging before 0:00 UTC.
- After 0:00 UTC, open CWA, navigate to the fragment where you are able to activate Exposure logging.
- Enable Exposure Logging. Immediately navigate back to the main screen.
- See error:
- Tap and hold risk card:
- release finger, see CWA navigating to risk details:
- navigate back to main screen, wait for refresh of risk card:
- wait for refresh of risk card after DKs had been provided to ENF:
Technical details
- Mobile device: LG-G4
- Android version: 6,1
- CWA; 1.6.0
- ENF: 18204215000
Possible Fix
Make sure that for UI states “Daten werden heruntergeladen…” and “Prüfung läuft…:” the correct background color is set when navigating from any other fragment to main screen.
edit:
Probably the bug is here:
it’s probably here
Looks like R.color.card_unknown
has background color white, or RiskLevelConstants
should be defined for “Daten werden heruntergeladen…” and “Prüfung läuft…”.
edit2: Would maybe make sense to define RiskLevelConstants
for “Daten werden heruntergeladen…” und “Prüfung läuft…”: Looks like while download RiskLevelConstants
is unknown, and while “Prüfung läuft…” RiskLevelConstants
is already “Low risk”.
edit3: Digging some more, for me seems that R.color.card_unknown
should point to color scheme <color name="colorSemanticNeutralRisk">#5D6E80</color>
, but obviously <color name="colorSemanticUnknownRisk">#FFFFFF</color>
is used:
See also here for definition of
RiskLevelConstants
:save your time not looking here
Additional context
Feel free to hide above screenshots for better readability of this issue, after mirroring to Jira.
Related PR https://github.com/corona-warn-app/cwa-app-android/pull/1751. Overall PR: https://github.com/corona-warn-app/cwa-app-android/pull/1699
Internal Tracking ID: EXPOSUREAPP-3834
Issue Analytics
- State:
- Created 3 years ago
- Comments:10 (10 by maintainers)
Top GitHub Comments
Hey @vaubaehn ,
I’ve mirrored this issue to Jira (ticket ID: EXPOSUREAPP-3834) now so that it gets properly tracked. We will see what we can do about it before the next release. As always, we’ll notify you here when a fix is available.
Thanks for the report, CH
Corona-Warn-App Open Source Team
Hi @vaubaehn and community, Thank you for your contributions. This issue has been fixed. We will close this ticket now. Many thanks, best regards. DS
Corona-Warn-App Open Source Team