Transposed "Max, Mustermann" in screenshots
See original GitHub issueAvoid duplicates
- Bug is not mentioned in the FAQ
- Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
- Bug is not already reported in another issue This issue is partially mentioned in https://github.com/corona-warn-app/cwa-app-android/issues/3926.
Technical details
- Device name: Samsung Galaxy A52 5G SM-A526B/DS
- Android version: 11
- App version: 2.7.1, 2.8.0, 2.9.0-RC1 (pre-release)
Describe the bug
Screenshots generated by
RecoveryCertificateDetailFragmentTest.kt
and
VaccinationDetailsFragmentTest.kt
render the example name as “Max, Mustermann”, where Name and First Name are transposed.
for example:
RecoveryCertificateDetailsFragment_recovered.png
- https://www.coronawarn.app/assets/screenshots/2-7/en/android/RecoveryCertificateDetailsFragment_recovered.png
- https://www.coronawarn.app/assets/screenshots/2-8/en/android/RecoveryCertificateDetailsFragment_recovered.png
VaccinationDetailsFragment_expired.png
- https://www.coronawarn.app/assets/screenshots/2-7/en/android/VaccinationDetailsFragment_immune.png
- https://www.coronawarn.app/assets/screenshots/2-8/en/android/VaccinationDetailsFragment_immune.png
Incorrect screenshots are currently also contained in the draft PR https://github.com/corona-warn-app/cwa-website/pull/1668 “Android Screenshots for Version: 2.9.0” for later publishing to https://www.coronawarn.app/en/screenshots/ when 2.9.x is released.
Steps to reproduce the issue
In CWA:
- Tap “Certificates” tab on Start Screen (tap “CONTINUE” if prompted)
- Tap “+ CERTIFICATE”
- Scan a valid vaccination certificate
- Check that the name under “Name, Vorname / Name, First Name” is rendered in that order
In Android Studio:
- Run RecoveryCertificateDetailFragmentTest.kt
- Run VaccinationDetailsFragmentTest.kt
- View > Tools Windows > Device File Explorer
- Go to /data/data/de.rki.coronawarnapp.test/screenshots
- Note that example name is incorrectly rendered as “Max, Mustermann”
Expected behavior
From CWA Android 2.7 onwards the formatting of the name was corrected for regular app usage, so screenshots should show the example name as “Mustermann, Max”.
Possible Fix
In RecoveryCertificateDetailFragmentTest.kt
and in VaccinationDetailsFragmentTest.kt
change
every { fullNameFormatted } returns "Max, Mustermann"
to
every { fullNameFormatted } returns "Mustermann, Max"
Additional context
Issue https://github.com/corona-warn-app/cwa-app-android/issues/3692 “Vaccination Details Screen: Firstname Surname in wrong order” was fixed through PR https://github.com/corona-warn-app/cwa-app-android/pull/3826 which fixed the issue in CWA Android 2.7. for:
- Recovery Certificates
- Test Certificates
- Vaccination Certificates
Internal Tracking ID: EXPOSUREAPP-9233
Issue Analytics
- State:
- Created 2 years ago
- Comments:9 (9 by maintainers)
Top GitHub Comments
@MikeMcC399 Thanks for confirming the fix. Forwarded to internal ticket.
The issue has been corrected for Android screenshots for CWA 2.9 published today, Sept 8, 2021, for example:
and for future version screenshots.