question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Change the type of "rolling start number" and "rolling period" on "diagnosis keys" to int.

See original GitHub issue

Current Implementation

Currently, the type of the rolling start number and rolling period on diagnosis keys is long, see here.

Suggested Enhancement

Change both to int. Also consider renaming “rolling start number” to “rolling start interval number”, as that was changed in the spec as well.

Expected Benefits

Newest Apple/Google spec changed the rolling start interval number of temporary exposure keys to int32 (see here), which is int in Java. With the proposed change, we can avoid unnecessary type conversions.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
stevesapcommented, May 22, 2020

@Akshatt yes that makes sense

0reactions
Akshattcommented, May 22, 2020

Hi @stevesap, I’ve forked and cloned the repo and have made changes where rolling start number and rolling period were defined. Should I also change long to int where they are passed as argument (See here) and returned (See here ) as well? Thanks for helping!

Read more comments on GitHub >

github_iconTop Results From Across the Web

cwa-server/DiagnosisKeyRepository.java at main · corona-warn-app ...
@param rollingStartIntervalNumber The rolling start interval number of the diagnosis key. * @param rollingPeriod The rolling period of the diagnosis key.
Read more >
Setting Up a Key Server | Apple Developer Documentation
Retrieve diagnosis keys so they can check for potential exposures. Submit temporary exposure keys · The period of time covered by the data...
Read more >
Rollover API | Elasticsearch Guide [master] | Elastic
The rollover API creates a new index for a data stream or index alias. The API's behavior depends on the rollover target. Roll...
Read more >
API for Exposure Notifications - Google Developers
The number of 10-minute intervals that a key is valid for. The expiration date for a key can be calculated by adding rollingPeriod...
Read more >
Chapter 4: Appenders - Logback
Depending on its kind, an appender may fail to start if certain ... archive files in a folder structure different than that of...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found