Cypress check_anchor_links.js misses issues in FAQ

Where to find the issue

cypress/integration/check_anchor_links.js

Describe the issue

The Cypress test cypress/integration/check_anchor_links.js does not find anchor link issues in the new FAQ structure under https://www.coronawarn.app/en/faq/results/ and https://www.coronawarn.app/de/faq/results/

Steps to reproduce

Manually introduce a bad anchor link into /src/data/faq.json.

npm run test:open Select check_anchor_links.js Note that the bad anchor link is not found

Suggested change

Add the directories:

• /en/faq/results/ and
• /de/faq/results/

to

cypress/integration/check_anchor_links.js

This is however not sufficient as then the test fails with a syntax error:

  1) Check for broken anchor links
       "/de/faq/results/" - Check for broken anchor links:
     Error: Syntax error, unrecognized expression: #

[MikeMcC399]

Alternative confirmation as follows:

npx cypress run -s cypress/integration/check_anchor_links.js -c baseUrl=https://coronawarn.app

This command runs check_anchor_links.js on the production website https://coronawarn.app in headless mode using the default Electron browser.

$ npx cypress run -s cypress/integration/check_anchor_links.js -c baseUrl=https://coronawarn.app


====================================================================================================

  (Run Starting)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Cypress:    7.7.0                                                                              │
  │ Browser:    Electron 89 (headless)                                                             │
  │ Specs:      1 found (check_anchor_links.js)                                                    │
  │ Searched:   cypress\integration\check_anchor_links.js                                          │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


────────────────────────────────────────────────────────────────────────────────────────────────────

  Running:  check_anchor_links.js                                                           (1 of 1)
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db

Why you should do it regularly:
https://github.com/browserslist/browserslist#browsers-data-updating


  Check for broken anchor links
    √ Check if txt results exist
    √ "/de" - Check for broken anchor links (4683ms)
    √ "/en" - Check for broken anchor links (2385ms)
    √ "/de/eventregistration/" - Check for broken anchor links (1747ms)
    √ "/en/eventregistration/" - Check for broken anchor links (1770ms)
    √ "/de/community/" - Check for broken anchor links (1085ms)
    √ "/en/community/" - Check for broken anchor links (1386ms)
    √ "/de/analysis/" - Check for broken anchor links (2713ms)
    √ "/en/analysis/" - Check for broken anchor links (1826ms)
    √ "/de/blog/archiv/" - Check for broken anchor links (1961ms)
    √ "/en/blog/archive/" - Check for broken anchor links (1423ms)
    √ "/de/screenshots/" - Check for broken anchor links (1562ms)
    √ "/en/screenshots/" - Check for broken anchor links (2237ms)
    √ "/de/faq/" - Check for broken anchor links (1715ms)
    √ "/de/faq/results/" - Check for broken anchor links (3021ms)
    √ "/en/faq/" - Check for broken anchor links (799ms)
    √ "/en/faq/results/" - Check for broken anchor links (3605ms)
    √ "/de/rat-partner/" - Check for broken anchor links (1924ms)
    √ "/en/rat-partner/" - Check for broken anchor links (1281ms)
    √ "/de/privacy/" - Check for broken anchor links (831ms)
    √ "/en/privacy/" - Check for broken anchor links (931ms)
    √ "/de/terms-of-use/" - Check for broken anchor links (1072ms)
    √ "/en/terms-of-use/" - Check for broken anchor links (1367ms)
    √ "/de/event-qr-code-guide/" - Check for broken anchor links (2874ms)
    √ "/en/event-qr-code-guide/" - Check for broken anchor links (2011ms)
    √ "/de/blog/" - Check for broken anchor links (1389ms)
    √ "/en/blog/" - Check for broken anchor links (1697ms)
    √ "/de/science/" - Check for broken anchor links (1054ms)
    √ "/en/science/" - Check for broken anchor links (1101ms)
    √ "/de/simple-language/" - Check for broken anchor links (4813ms)
    √ "/en/simple-language/" - Check for broken anchor links (1016ms)
    √ "/de/sign-language/" - Check for broken anchor links (1710ms)
    √ "/en/sign-language/" - Check for broken anchor links (2467ms)

  Check for broken anchor links on entries
    √ "/de/blog/" entries - Check for broken links (3517ms)
    √ "/en/blog/" entries - Check for broken links (2101ms)
    √ "/de/science/" entries - Check for broken links (967ms)
    √ "/en/science/" entries - Check for broken links (786ms)


  37 passing (1m)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        37                                                                               │
  │ Passing:      37                                                                               │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        false                                                                            │
  │ Duration:     1 minute, 9 seconds                                                              │
  │ Spec Ran:     check_anchor_links.js                                                            │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


====================================================================================================

  (Run Finished)


       Spec                                              Tests  Passing  Failing  Pending  Skipped
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ √  check_anchor_links.js                    01:09       37       37        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    √  All specs passed!                        01:09       37       37        -        -        -

[MikeMcC399]

Thanks to @ahodzic2 for investigating the Cypress test cypress/integration/check_anchor_links.js, adding the directories /en/faq/results and /de/faq/results and resolving the syntax issue arising! 👍🏻

The steps npm run test:open Select check_anchor_links.js

cause the test to run to completion. Bad links in

• /en/faq/results and
• /de/faq/results are now identified.

Therefore this issue is now resolved.

See also:

• https://github.com/corona-warn-app/cwa-website/issues/2666
• https://github.com/corona-warn-app/cwa-website/pull/2657