question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Include `check_links.js` check into GitHub workflow (build and test)

See original GitHub issue

Feature description

I suggest to integrate the check_links.js check, which currently has to be run manually on a local instance of the website, into the build and test GitHub Action which runs for every commit in a PR:

Problem and motivation

This feature would save work and broken links can be found more easily.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:13 (13 by maintainers)

github_iconTop GitHub Comments

2reactions
MikeMcC399commented, Dec 4, 2021

There was an issue in September 2020 with running the Cypress tests as part of the build. (This was before link-checking was introduced.) PR https://github.com/corona-warn-app/cwa-website/pull/385 removed the tests from the Cypress workflow.

2reactions
MikeMcC399commented, Oct 22, 2021

@dsarkar

still I think it is too much time to include it into the deployment workflow.

The tests are still evolving and I agree that it is good to keep it out of the deployment workflow at the moment. It is a big step forward to have it testing all links.

I’m still learning about Cypress, but I did find that there was a problem running headless when I looked at the 8.6.0 version https://github.com/corona-warn-app/cwa-website/issues/1947. I presume this would need to be solved before integrating into any workflow.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Using scripts to test your code on a runner - GitHub Docs
When this workflow is triggered, it automatically runs a script that checks whether the GitHub Docs site has any broken links. The following...
Read more >
Check links with linkcheck · Actions · GitHub Marketplace
It is 40 times faster than the only tool that goes to the same depth (linkchecker). Finds all relevant problems. No link-checker can...
Read more >
Building and testing Node.js - GitHub Docs
Introduction. This guide shows you how to create a continuous integration (CI) workflow that builds and tests Node.js code. If your CI tests...
Read more >
A GitHub Action driver for link-check, deployed via submodules.
This script searches through the source file content of either a directory or a git branch's difference from main. This means it's possible...
Read more >
My Broken Link Checker · Actions · GitHub Marketplace
This is a GitHub Action to check broken link in your static files or web pages. The muffet is used for URL checking...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found