Non-working link to #background / #Hintergrund
See original GitHub issueWhere to find the issue
-
https://www.coronawarn.app/en/ section “This is how the app works best”
…
3. Keep background updates switched on and check them regularly -
https://www.coronawarn.app/en/ section “So funktioniert die App am besten”
…
3. Hintergrundaktualisierung immer einschalten und kontrollieren
Describe the issue
The hyperlink target https://www.coronawarn.app/en/faq/#background used by
3. Keep background updates switched on and check them regularly
does not exist. Instead it causes a search to be done on the term “background”.
The hyperlink target https://www.coronawarn.app/en/faq/#Hintergrund used by
3. Hintergrundaktualisierung immer einschalten und kontrollieren
does not exist. Instead it causes a search to be done on the term “Hintergrund”.
Suggested change
https://github.com/corona-warn-app/cwa-website/pull/438 from @Ein-Tim suggested the change to refer to #background and #Hintergrund
I tried changing the link back to use faq/#background_updates
and it worked as I expected, by opening the section
en/faq/#background_updates “Background Updates”
@Ein-Tim Do you know why href='faq/#background_updates'
was causing problems when you made the change last year? Is there a reason that we could not correct this by reverting to the original link using faq/#background_updates
to refer to https://www.coronawarn.app/en/faq/#background_updates?
Issue Analytics
- State:
- Created 2 years ago
- Comments:6 (6 by maintainers)
Top GitHub Comments
@Ein-Tim Thanks for checking!
Since October 2020 many of the components used for the website have been updated, so there may have been a bug there in one of the old npm modules or the web server itself.
The important thing is that it is working as intended 🙂 …
… so now closing this issue, resolved with #1670.
@Ein-Tim
I tried making the changes and then testing using
npm start
and it worked. I also copied the server files onto a local nginx server and the changes worked there too.I will submit a PR to make the changes and hopefully it will work in the CWA production environment too.
In https://github.com/corona-warn-app/cwa-website/pull/438 there is only a screenshot of the link, not the actual hyperlink itself, so it is difficult to understand why it wasn’t working correctly at the time.