[BUG] Unsaved changes on double click
See original GitHub issueSteps to reproduce the bug
- Open a
.plist
file - Double click on any text field but DO NOT change the content
- ProperTree reports unsaved changes
Expected behaviour
ProperTree shouldn’t report unsaved changes if there’s no change (everyone would agree on that 😄)
Any possible fix?
Issue Analytics
- State:
- Created a year ago
- Comments:25 (13 by maintainers)
Top Results From Across the Web
Accidentally Clicked "Don't Save" in Microsoft WordIntegris
If you see the file's name in this pane, double click on it, then select File>Save to save the document as a .docx...
Read more >Double click on a line in "find results" does not go to ... - GitHub
With the Find results window, the function of double click does not work for an unsaved new document. Steps to Reproduce the Issue....
Read more >How to recover unsaved Word documents - Microsoft Learn
Restarting Word to open AutoRecover files If this occurs, double-click the file name in the Document Recovery pane, select File > Save as,...
Read more >Warn user before leaving web page with unsaved changes
Short, wrong answer: You can do this by handling the beforeunload event and returning a non-null string: window.addEventListener("beforeunload", function ...
Read more >Bug #1481808 “MARC editor unsaved changes dialog does not fire ...
Bug Description · 1. Copy text to your clipboard. · 2. Navigate to the MARC editor interface. · 3. Paste the copied text...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Just as a side note on this - it’s possible, but would require serializing the plist, then gathering a checksum every time something may or may not be changed - which could end up being very slow on larger plists, slower hardware, or with users that make quick edits (or even just
enter
thenesc
a ton). I’m hoping to be able to just catch any changes the user might make, apply some simple-ish checks to see if we actually changed anything - then apply the- Edited
as needed.Perfect! As for Windows and Linux - I’ve not even been able to reproduce the double-click/drag-oriented issue locally, so I’ve just been going off your debugging, and I don’t personally use Linux so that will have to be checked by other users I suppose.
The changes are pushed though - and I’ll leave this issue open for awhile in case anyone else runs into it - but if it goes a couple weeks without additions, I’ll consider it closed.
Thanks for testing, glad we got it ironed out. Let me know if you run into other oddities!
-CorpNewt
That making the code work doesn’t really make sense though - as it’s immediately evaluated in the next line if the function didn’t return:
And if we turn off the
self.edited
, but the file had already been edited, the title would become- Edited - Edited
- which just adds another bug. I’ll see if I can reorder when the drag locks are applied to avoid any sort of race conditions.