question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

build script not failing the npm script

See original GitHub issue

there are two issues with build.js

  1. after running the webpack config. the error condition check is incorrect. it should be
stats.hasErrors()

instead of

jsonStats.hasErrors
  1. if there are any issues with the build then the npm script doesnt exit with error code. maybe use process.exit(1)

Issue Analytics

  • State:open
  • Created 6 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
kwelchcommented, Jul 20, 2017

You should be able to push to your own fork and PR from that fork.

1reaction
atamaku1commented, Jul 17, 2017

ok cool!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Build stage not failing on npm script exit status 2 #424 - GitHub
If I do, my bash command to run an npm build script is exiting with error 2 and the build step still continues...
Read more >
npm run build - fails to compile despite development version ...
Failed at the portfolio@0.1.0 build script. npm ERR! This is probably not a problem with npm. There is likely additional logging output ...
Read more >
scripts - npm Docs
To create "pre" or "post" scripts for any scripts defined in the "scripts" section of the package.json , simply create another script with...
Read more >
Build not failing when npm returns a non zero exit code
As per screenshot, I have a build step that is not reporting a failure even though my build script is failing. The output...
Read more >
Build was terminated: Build script returned non-zero exit code ...
Deploy failed NPM. I am facing the error on deployment. Error on deployment. Build script returned non-zero exit code: 2 - I added...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found