Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update ESLint Config

See original GitHub issue

After the changes made in #405, there is a lot of eslint config now in the package.json.

In effort to clean this up, there was a suggestion to move Slingshot to a baseline preset.

This issue is to capture that ask and open the discussion to others about what the eslint config preset should be set to.

Options

ESLint Recommended Baseline
- Do we include other recommended baselines (ie. react, import, etc.)
ESList shared preset
- Which preset?
  - AirBnB - No - too opinoinated see #35
  - CRA?
  - Standard/Standard-Semi?
Package Slingshot Config
- Is the current config at a place that is right sized and can be shared as a packaged config

Issue Analytics

State:
Created 6 years ago
Comments:23 (10 by maintainers)

Top GitHub Comments

6reactions

kwelchcommented, Aug 16, 2017

Not sure.

@coryhouse & @nickytonline,

How do you feel about the eslint rules? Should adopt or create a single preset that has all options needed? Or should we just remove rules and use the presets we currently have?

Please vote: 👍 - Create eslint-config-slingshot 🎉 - Remove all rules ❤️ - Use Preset (reply with recommended config)

3reactions

kwelchcommented, Apr 11, 2017

I think we are solid on the approach. Adding a help wanted and good first PR label. 😄

Top Results From Across the Web

Configuring ESLint - ESLint - Pluggable JavaScript Linter

A pluggable and configurable linter tool for identifying and reporting on patterns in JavaScript. Maintain your code quality with ease.

eslint - npm

Basic Features: ESLint - Next.js

If either of the two configuration options are selected, Next.js will automatically install eslint and eslint-config-next as development dependencies in your ...

silvermine/eslint-config-silvermine - GitHub

Update ESLint in @silvermine/eslint-config. Open a PR that contains this update and the @silvermine/eslint-plugin update from step 2. Note: All of the linting ......

ESLint | WebStorm Documentation - JetBrains

Configure ESLint manually · In the Settings/Preferences dialog ( Ctrl+Alt+S ), go to Languages & Frameworks | JavaScript | Code Quality Tools | ......