How about adding main signer address data into SigningCosmWasmClient?

Currently there’s no field to hold a signer address data or method to get that kind of data in SigningCosmWasmClient class. But, considering the usage of that class, why don’t we add an address string data into the class or some addresses to make it more complement class for a literally signing client?

@ethanfrey @webmaster128

[webmaster128]

Indeed, the client can have one signer address which can be changed. A big API change would still result from making the client a one-address client.

We could try creating a SimpleSigningCosmWasmClient to test if that works well.

[ethanfrey]

In ts-relayer, I made a simple wrapper that had this hardcoded address. That would not work if used in a web-app using Keplr, where you change account.

The fact that the wallet is completely hidden inside the signing client has been an annoying client side DevX for a while. But adding one more fixed field is not a proper solution. I would propose adding two more methods here:

// also in SigningCosmosClient
class SigningCosmWasmClient {
    public getAccounts(): Promise<readonly AccountData[]> {
        return this.wallet.getAccounts();
    } 

    // return address of the first account
    public async mainSigner(): Promise<string> {
        const accounts = await this.wallet.getAccounts();
        return accounts[0].address;
    } 
}

This means you can simply pass around a SigningClient, without needing to pass along either the wallet or an address to know how to sign it.

I agree with requiring the senderAddress in all the functions still, but at least this way we can find the proper address much easier. Other wrappers (outside of CosmJS) could then auto-fill in this field if they want, but this is the only change I would make in CosmJS to enable ease of use.