sendTransaction based on sendToken

There could be a more generalized version of sendToken that sends a custom transaction. So, it would get account number, sequence and chain id, use an existing client, post request (base_req and body) to an API to get a formed tx, sign it locally and broadcast it to the chain.

Something like this:

async sendTransaction({ state }, { type, body }) { // don't mind the state, it's a Vuex thing
  const { accountNumber, sequence } = await state.client.getNonce();
  const address = state.client.senderAddress;
  const chain_id = await state.client.getChainId();
  const req = {
    base_req: { chain_id, from: address },
    creator: address,
    ...body,
  };
  const { data } = await axios.post(`${API}/${chain_id}/${type}`, req);
  const { msg, fee, memo } = data.value;
  const signBytes = makeSignBytes(
    msg,
    fee,
    chain_id,
    memo,
    accountNumber,
    sequence
  );
  const signatures = [await state.wallet.sign(signBytes)];
  const signedTx = { msg: msg, fee, memo, signatures };
  return await state.client.postTx(signedTx);
}

Pretty useful method to have.

[webmaster128]

Very good idea.

Looking at packages/cosmwasm/src/signingcosmwasmclient.ts you also see a lot of repetition of this code:

    const fee = this.fees.exec;
    const { accountNumber, sequence } = await this.getNonce();
    const chainId = await this.getChainId();
    const signBytes = makeSignBytes([executeMsg], fee, chainId, memo, accountNumber, sequence);
    const signature = await this.signer.sign(this.senderAddress, signBytes);
    const signedTx: StdTx = {
      msg: [executeMsg],
      fee: fee,
      memo: memo,
      signatures: [signature],
    };

    const result = await this.postTx(signedTx);
    if (isPostTxFailure(result)) {
      throw new Error(createPostTxErrorMessage(result));
    }

So the same sendTransaction should be created in SigningCosmWasmClient and SigningCosmosClient

[webmaster128]

Thank you Ethan! I agree this is a more general solution to the problem. However, I don’t think we will get it sufficiently refned and implemented this week and in 0.22.0. I created a new ticket here: https://github.com/CosmWasm/cosmjs/issues/316. I’ll close this ticket with a smaller change of the current code.