Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Contributor Form emails sending when fields are empty

See original GitHub issue

from models.ContributorForm

    def should_notify(self):
        """
        If this evaluates to true, we send an email to the recruitment team.
        """
        return (
            (self.ideas != None)
            | (self.features != None)
            | (self.experience != None)
            | (self.contribute_ways != None)
            | (self.expertise != None)
        )

however emails are being sent when all should be None

Issue Analytics

State:
Created 2 years ago
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

faizjamilcommented, Aug 23, 2021

Yes, I need to do a quick look through of SQLAlchemy today and see where to go from there.

On Mon, Aug 23, 2021, 5:02 AM Itsi Weinstock @.***> wrote:

Hey @faizjamil https://github.com/faizjamil are you still working on this? This is becoming a higher priority issue for us receiving the empty emails

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Couchers-org/couchers/issues/1770#issuecomment-903577391, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUCMSX2PGJIVPCU4HR6A5DT6IFA7ANCNFSM5BRLDRQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

0reactions

faizjamilcommented, Sep 6, 2021

Go for it.

On Mon, Sep 6, 2021, 11:16 AM Aapeli Vuorinen @.***> wrote:

Hey; sorry. I’m going to grab this and fix it up quick. The support team is getting frustrated with the bombardment of emails, and I think debugging this requires having a look at the existing rows in the DB!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Couchers-org/couchers/issues/1770#issuecomment-913722050, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUCMSXLWCTUWBSH5BPZ7C3UATLNXANCNFSM5BRLDRQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.