Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add `[xunit]` to default excluded modules filter

See original GitHub issue

@vagisha-nidhi’s comment

Also, I have been trying out things with xunit/nunit and I found this https://github.com/tonerdo/coverlet/issues/361#issuecomment-470044541. This would be a bad experience for any first user, if a test run crashes with --collect:“Xplat code coverage”.

Should we add [xunit*]* to default exclude filter here https://github.com/tonerdo/coverlet/blob/master/src/coverlet.collector/Utilities/CoverletConstants.cs#L21?

cc: @cltshivash @tonerdo @onovotny

Issue Analytics

State:
Created 4 years ago
Comments:15 (6 by maintainers)

Top GitHub Comments

1reaction

MarcoRossignolicommented, Jun 11, 2019

@vagisha-nidhi you can test with nightly if you want https://www.myget.org/feed/coverlet-dev/package/nuget/coverlet.collector/1.0.33-g66a0119867 FYI consume nightly instructions https://github.com/tonerdo/coverlet/blob/fe775360460a6855e0492b28cb41a2b5f2d9b0d3/Documentation/ConsumeNightlyBuild.md

1reaction

MarcoRossignolicommented, Jun 10, 2019

I would also suggest it exclude .test.dll/.tests.dll assemblies as you almost never want to instrument and report on the unit test assembly itself.

@onovotny at the moment we exclude by default test assembly, added back in https://github.com/tonerdo/coverlet/pull/376 after some discussions, @sharwell has got a different point of view 😄