Coverlet changes order of attributes

Versions: dotnet core 2.1 asp.net core 2.1.5 coverlet 2.5.0

Some of our tests that rely on the order of asp.net ValidationAttributes for method parameters fail when run with coverlet. Coverlet instrumentation seems to change the order of attributes.

e.g.

  method.GetParameters().ForEach(p =>
            {
                var validationAttributes = p.CustomAttributes.Where(a => typeof(ValidationAttribute).IsAssignableFrom(a.AttributeType))
                    .Select(a => a.AttributeType).ToList();
                if (validationAttributes.All(a => a != typeof(ShouldBeFirstAttribute))) return;
                if (validationAttributes.First() != typeof(ShouldBeFirstAttribute))
                {
                    Assert.Fail("Action: {0}.{1}(...) should have {2} declared before other validation attributes", type.FullName, method.Name,
                        typeof(ShouldBeFirstAttribute).Name);
                }
            });

This passes when run with \p:CodeCoverage=false

[dorgold]

Thanks @MarcoRossignoli! Just found a workaround till then, i’ll use the Order property of ActionFilterAttribute: https://docs.microsoft.com/en-us/aspnet/core/mvc/controllers/filters?view=aspnetcore-2.2#overriding-the-default-order

[MarcoRossignoli]

@dorgold I opened a PR to upgrade Cecil lib https://github.com/tonerdo/coverlet/pull/508 to avoid reordering…you can use nightly untill next release https://github.com/tonerdo/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md