question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Delete observation functionality

See original GitHub issue

Summary

We want to give users the ability to delete any observation they wish

Acceptance Criteria

  • Add ability to swipe right on a WeeklyTracker for a specific observation
  • on right-swipe, implement a Dialog asking if the user is sure they want to delete, and then a redux thunk to delete that observation (using Gaia deleteFile())
  • update UI to reflect that deleted observation

Motivation

Both to give users a sense of ownership over their data (since they do own it) and… for way down the line… to comply with GDPR guidelines that users should always be able to delete their data upon request.

Describe alternatives you’ve considered

None, this is necessary

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:15 (15 by maintainers)

github_iconTop GitHub Comments

1reaction
fallon7284commented, Apr 13, 2020

Yeah the date would always be unique. It is sort of a large change that goes well outside the scope of this issue.

I wonder if the sort of hacky solution of just replace it with a null value is ultimately still perfectly acceptable? It would just require a small tweak in the fetch thunk to filter out those null values from the list we add to the redux store.

Otherwise like I said it’s a much larger change. @SomeMoosery Thoughts? I just changed this 2 days ago but honestly hadn’t considered that we would want to delete observations or I would have just done what i proposed above in the first place.

1reaction
fallon7284commented, Apr 13, 2020

Maybe a better long term solution is actually that observations.json is an object where keys are the date and the name of the single backup file is also just like observations/{theDate}.json.

So a user deleting an observation where date: 1586646434498 would just be fetch observations.json, delete observations[“1586646434498”] and repost it, and then deleteFIle observations/1586646434498.json

Read more comments on GitHub >

github_iconTop Results From Across the Web

Delete Observations - SAS Help Center
The DELETE statement marks observations for deletion. To actually delete the marked observations and renumber the remaining observations, use ...
Read more >
Delete Rows Based on a Cell Value (or Condition) in Excel ...
Right-click on any of the cells and click on Delete Row Click on Delete Row Option for filtered row based on numbers; In...
Read more >
Add Delete Functionality to a Table View Row | by LeAnne M Lis
It's easy and quick to add a default Delete button, as well as “swipe to delete” functionality, to table view rows in iOS....
Read more >
Add and Delete Row Functionality by Using Visualforce Page ...
It is simple to add and remove rows in visualforce page. Try the below code and you will get some ideas,. Visualforce Page...
Read more >
How to Delete a Column/Row From a DataFrame using Pandas
You can use the drop function to delete rows and columns in a Pandas DataFrame. Let's see how. First, let's load in a...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found