Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Point me in the right direction: adding media print support

See original GitHub issue

I want to use print js and i want it to detect and use my @media print{} style block. point me in the right direction for adding this support, so i can get a PR open and merged and hopefully you can crank out a new version asap. i need this bad, so bad i will do the PR myself. just need a bit of a push in the right direction. i’m not super familiar with typescript but i did work on a few angular2/4 projects so i know enough to probably get it done.

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:8 (7 by maintainers)

Top GitHub Comments

3reactions

r3wtcommented, May 17, 2018

@crabbly First, i’d like to thank the crabbly team for their work on this matter. Second, i’d like to think the author of the PR, @zikkAbdelaziz . Thank you Zakaria. Thank you Crabbly Team. I got busy and ended up just bailing on the PR in favor of the path of least resistance, which was just rolling my own using @media print and window.print(). In the future, i’ll probably take a look at migrating to this library if it makes sense. Thank you all again for your hard work, i appreciate it, and i’m sure there will be others that will come along to appreciate your hard work as well. Have a blessed day. Garrett

2reactions

zikkcommented, May 17, 2018

@r3wt You’re welcome @crabbly Check out #168