Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Code cleanup: use classes

See original GitHub issue

I think it would be much better if we move away from loose functions and use classes for Skin, Avatar, Render, Cape, Profile, etc. This would make things a lot easier.

for example:

var skin   = new Skin(uuid);
var avatar = new Avatar(skin, true);

Issue Analytics

State:
Created 8 years ago
Comments:6 (4 by maintainers)

Top GitHub Comments

1reaction

jengel3commented, May 26, 2016

@RobertHerhold Having any discussion here would be best. Future contributors can reference it and anyone that has ideas/concerns can chime in here.

0reactions

jomocommented, May 26, 2016

if (err || (is_uuid && !profile)) {
  // error or uuid without profile
  if (!err && !profile) {
    // no error, but uuid without profile

As commented below the line, it’s possible to have a UUID but not have a profile, which means the user does not exist. The comment doesn’t really indicate that, sorry. It was introduced in 3fdd942c0f1c507b86bb530adf051c9dac64aeef as a fix for #93.

PS: When you link to source code on GitHub, press Y to get a permalink.