question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Extended chords not mapped correctly?

See original GitHub issue
  • Does mir_eval handle extended chords correctly? It seems to ignore everything beyond the seventh:
In [5]: mir_eval.chord.encode('A:maj(9)')
Out[5]: (9, array([1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 0, 0]), 0)

In [6]: mir_eval.chord.encode('A:maj(9)', reduce_extended_chords=True)
Out[6]: (9, array([1, 0, 0, 0, 1, 0, 0, 1, 0, 0, 0, 0]), 0)

compared to

In [8]: mir_eval.chord.encode('A:maj(2)')
Out[8]: (9, array([1, 0, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0]), 0)
  • Does it make sense to treat chords such as A:maj(9) and A:maj(2) differently in the first place? Both comprise the same pitch classes, and I doubt that one can distinguish between the two in the sound mixture of e.g. a pop/rock song.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:16 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
fdlmcommented, Aug 23, 2017

Yes, I think this is fixed now, thanks! 👍

0reactions
ejhumphreycommented, Aug 23, 2017

i do believe so, but would default to @fdlm

Read more comments on GitHub >

github_iconTop Results From Across the Web

Learning Extended Chords for Guitarists | Beginner Guitar HQ
Extended chords built upon a major or minor seventh chord are constructed and notated differently from their dominant cousins. A maj9 chord, ...
Read more >
5.4 Beyond Triads: Naming Other Chords - EarMaster
Take care to use the correct third and seventh - dominant, major, or minor - with extended chords. If the higher note is...
Read more >
Jazz Guitar Extended Chords - YouTube
This lesson is on how to play jazz guitar extended chords. Add 9s, 11s, and 13s to basic jazz chords on the guitar....
Read more >
Diminished Guitar Chords - How & When to Play - Fretjam
Get a deep understanding of diminished guitar chords, their function and application, including diminished seventh chords and half diminished chords.
Read more >
Avoid Notes, Tension Notes and Extended Chords
Answer: all tensions can be used, except the fourth degree. That is, we cannot play C4 or Cmaj7(4). Reason: in this context, the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found