Fix source separation unit tests
See original GitHub issueTagging @faroit @ecmjohnson
At some point in the last six months, the regression tests for source separation have started failing, specifically on fixtures output00
(Images Frames - Source to Interference and Artifact) and output04
(Images - Source to Interference and Artifact).
Anyone know what’s going on here? The results are off by up to 1e-2 in some cases, so I don’t think this is up to json encoding round-off error. Maybe something changed under the hood in numpy or scipy since the fixtures were generated? If that’s all it is, then it should be a simple matter of revising the expected scores.
It looks like these fixtures were most recently updated by @ecmjohnson in #212 .
Issue Analytics
- State:
- Created 7 years ago
- Comments:8 (3 by maintainers)
Top Results From Across the Web
Software Design, Separation Of Concerns & Unit Testing
In particular, adherence to the principles of separation of concerns and modular design can make software easier to test.
Read more >How to Split JUnit Tests in a Continuous Integration Environment
In this tutorial you will learn how to split your JUnit tests, and why you need to split them if you're working on...
Read more >separation of unit testing not working · Issue #294 - GitHub
Hello I wanted to keep unit testing files in separate folder out of app/, I wanted to keep the outside of app/ as...
Read more >java - Separation of JUnit classes into special test package?
I put my test classes in the same package as what they are testing but in a different source folder or project. Organizing...
Read more >unittest — Unit testing framework — Python 3.11.1 ...
Source code: Lib/unittest/__init__.py(If you are already familiar with the basic ... check that s.split fails when the separator is not a string with...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
This seems fine to me.
They’re all blas enabled, it’s just a question of which blas. We could try to do a better job of matching the outputs to the test environments, but I think that’s sort of missing the point, and wouldn’t ensure that different users would get the same results on the same input anyway.
I tried locally on these two numpy builds.
This one passes:
This one fails: