Performance improvements

I’ve been doing some performance analysis with chrome dev tools because fps was pretty low for my usage.

1. PUID is really inefficient as it gets called a lot and iterate over the whole array of particles. Replacing the array with a Map looks like a better idea

export default {
    _id: 0,
    _uids: new Map(), //maps objects to IDs
    id: function (functionOrObject) {
        if (this._uids.has(functionOrObject))
            return this._uids.get(functionOrObject);

        const nid = 'PUID_' + this._id++;

        this._uids.set(functionOrObject, nid);

        return nid;
    }
};

1. Setting rotation for Sprites in MeshRenderer consumes a lot of CPU for nothing… as rotating a Sprite has no effect (you need to rotate the material)

constructor(container, THREE) {
        [...]
        this._THREE = THREE;
    }
[...]
onParticleUpdate(particle) {
        if (particle.target) {
            particle.target.position.copy(particle.position);
            if (!(particle.target instanceof this._THREE.Sprite))
                particle.target.rotation.set(
                    particle.rotation.x,
                    particle.rotation.y,
                    particle.rotation.z
                );
            this.scale(particle);

            if (particle.useAlpha) {
                particle.target.material.opacity = particle.alpha;
                particle.target.material.transparent = true;
            }

            if (particle.useColor) {
                particle.target.material.color.copy(particle.color);
            }
        }
    }

(alternatively, could override the whole function in SpriteRenderer)

Could you fix these or do you need a PR @rohan-deshpande ?

[rohan-deshpande]

Okay yep, it’s an issue, I will track this in a new issue and mention you there @davidpox thanks for reporting

[davidpox]

Hey all, I’m also testing the GPURenderer and the performance improvement is incredible. I’m having issues with rendering however, seems like depth-testing isn’t working.

System is created like so:

new Nebula.System.fromJSONAsync(json, THREE)
	.then(system => {
		this._system = system;
		this._emitter = this._system.emitters[0];
		this._emitter.emit();
		this._system.renderer = new Nebula.GPURenderer(this, THREE);
		this._system.addRenderer(this._system.renderer);
	});

Let me know if you want the Json data too.