possible assert issue when running under different nodejs vm contexts

The line at https://github.com/crossbario/autobahn-js/blob/d0d34813110f64127b2b76ecfa7eba7adda5a430/packages/autobahn/lib/session.js#L1217 fails for me on NodeJS 11 and 12, even though the kwargs parameter is an object.

I gave up debugging when seeing these watch values:

It’s not necessarily an autobahn related issue, but if I change those (and all related) checks to kwargs typeof === 'object', everything works fine.

I’ve seen you already had trouble with the array checks a while back, is there any chance to use typeof for the object checks aswell? I could create a PR for it!

[kuema]

That sounds reasonable.

Up to now we have worked around the “instanceof” problem by creating the object outside the VM. But a clean solution to this would be really appreciated.

there even seems to be a library these days https://github.com/moliqingwa/node-red-contrib-wamp

We don’t use that particular contrib node. It didn’t exist back then, so we developed our own with some more advanced features.

BTW: We have been using WAMP in conjunction with Node-RED for many years now. Quite the couple these two technologies. 😄

[oberstet]

I haven’t read any contribution guide, I hope all is well in the PR…

yeah, PR looked good, so merged! the issue should hence be fixed (on master)

also, no, we don’t have a contribution guide (we should … but in any case, you basically blended in code style etc into what’s there already, so cool)