Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Commit f0c83a3 breaks the 12.4 tests.

See original GitHub issue makes some changes to the file testdata/data1.html, which is used in the 12.4 block of tests for compression. I don’t yet understand why, but these changes break the tests 12.4.{5,6,8,9,10,11,13,14,15,16,17,18}.

I initially discovered this while maintaining my WebSocket libraries (, but I have reproduced the failures with the ws npm package, and with the file examples/twisted/websocket/echo_compressed/ in the autobahn-python repo.

The tests work fine with the 0.7.5 release. Taking the 0.7.5 package and removing the s from the end of WebSockets as is done in the above-linked commit is enough to make the test start failing.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:1
  • Comments:22 (4 by maintainers)

github_iconTop GitHub Comments

jcoglancommented, May 21, 2018

As the person that opened this issue, and as a fellow open-source maintainer, I’d like to emphasise that shaming people for not getting a fix out within some arbitrary time period is not productive and mostly leads to maintainers burning out.

Also, the value I’ve got from this software is substantial considering I didn’t have to pay for it, and there are many thousands of projects depending on software that’s better for having this test suite. If this issue gets fixed, that’ll be a nice bonus but I’m happy to work around it.

aaugustincommented, Aug 22, 2017

Fun fact about public reports: I believe any implementation that currently displays the 12.5.* test cases as passing is non-compliant — it accepts broken UTF-8 that it should reject 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

12.5.* test cases invalid utf8 splitting · Issue #71 - GitHub
I see the issue with some of the websocket compression tests (some of 12.4.*, e.g. with 12.4.5). I don't see in the git...
Read more >
peano magic on Twitter: "why I don't promise people release ... Commit f0c83a3 breaks the 12.4 tests. · Issue #77 · crossbario/autobahn-testsuite. f0c83a3 makes some changes to the file ...
Read more >
Find commit that broke a test without running every test on ...
Is there a tool, e.g. a continuous integration server, that can rerun failed tests with a couple of revisions in between the last...
Read more >
How I Use Git Bisect to Find Where My Test Broke - Atomic Spin
In this post, I'll talk about how I used the Git bisect tool to find the specific commit that caused my test to...
Read more >
Find the Commit which Broke the Test in Git - CodeProject
Find the first broken git commit. Scenario in Details. However, the main purpose of git is version control, it can also be useful...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Post

No results found

github_iconTop Related Hashnode Post

No results found