Commit f0c83a3 breaks the 12.4 tests.
See original GitHub issuehttps://github.com/crossbario/autobahn-testsuite/commit/f0c83a3d6ad157417b7d56091796d8c8798be9c0 makes some changes to the file testdata/data1.html
, which is used in the 12.4 block of tests for compression. I don’t yet understand why, but these changes break the tests 12.4.{5,6,8,9,10,11,13,14,15,16,17,18}.
I initially discovered this while maintaining my WebSocket libraries (https://github.com/faye), but I have reproduced the failures with the ws
npm package, and with the file examples/twisted/websocket/echo_compressed/server.py
in the autobahn-python repo.
The tests work fine with the 0.7.5 release. Taking the 0.7.5 package and removing the s
from the end of WebSockets
as is done in the above-linked commit is enough to make the test start failing.
Issue Analytics
- State:
- Created 6 years ago
- Reactions:1
- Comments:22 (4 by maintainers)
Top GitHub Comments
As the person that opened this issue, and as a fellow open-source maintainer, I’d like to emphasise that shaming people for not getting a fix out within some arbitrary time period is not productive and mostly leads to maintainers burning out.
Also, the value I’ve got from this software is substantial considering I didn’t have to pay for it, and there are many thousands of projects depending on software that’s better for having this test suite. If this issue gets fixed, that’ll be a nice bonus but I’m happy to work around it.
Fun fact about public reports: I believe any implementation that currently displays the 12.5.* test cases as passing is non-compliant — it accepts broken UTF-8 that it should reject 😃