feature request: `cameraMatrices` prop in `<Worldview />` component
See original GitHub issueAwesome library, thanks for all you do! 😺
I’d like to supply my own camera matrices to <Worldview />
instead of the cameraState
object.
the idea
<Worldview
cameraMatrices={{
view,
projection
}}
>
data model
// @flow
type CameraMatrices = {|
view: Mat4,
projection: Mat4,
|}
new behavior
<Worldview />
component checks for valid cameraMatrices
prop on mount and update, sets them in cameraStore
which uses them directly with priority over cameraState
benefits
adds support for arbitrary camera parameters in a standard format, expanding use cases
drawbacks
introduces more complexity to the camera state api
what do you think about this design? i’m eager to contribute if you think it fits.
Issue Analytics
- State:
- Created 4 years ago
- Comments:5 (2 by maintainers)
Top Results From Across the Web
3D Reconstruction of Plant/Tree Canopy Using Monocular ...
[27] developed a novel method to recover camera matrices and 3D points from unordered images. All these technologies were known as Structure from...
Read more >webviz from cruise-automation - Coder Social
feature request : `cameraMatrices` prop in `<Worldview />` component. Awesome library, thanks for all you do!. I'd like to supply my own camera...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
yeah, agreed if we have both docs and warnings, this should be fine.
we’ll have to see about this organization, since if the matrices are a separate prop from cameraState it doesn’t make as much sense to group them with the cameraState stories…but they are camera-related, so maybe it’s fine. You might find some opportunities to clean up the organization while you’re there.
Looking forward to your branch!
Cool, feel free to make a PR if you think it’s stable enough now. 😄