question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

feature request: `cameraMatrices` prop in `<Worldview />` component

See original GitHub issue

Awesome library, thanks for all you do! 😺

I’d like to supply my own camera matrices to <Worldview /> instead of the cameraState object.

the idea

<Worldview 
  cameraMatrices={{ 
    view, 
    projection
  }}
>

data model

// @flow

type CameraMatrices = {|
  view: Mat4,
  projection: Mat4,
|}

new behavior

<Worldview /> component checks for valid cameraMatrices prop on mount and update, sets them in cameraStore which uses them directly with priority over cameraState

benefits

adds support for arbitrary camera parameters in a standard format, expanding use cases

drawbacks

introduces more complexity to the camera state api

what do you think about this design? i’m eager to contribute if you think it fits.

Issue Analytics

  • State:open
  • Created 4 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
jtbandescommented, Nov 25, 2019

with the right docs and warnings, having a separate prop might be easier to understand

yeah, agreed if we have both docs and warnings, this should be fine.

  1. Make a story on the cameraState module that allows passing matrices directly

we’ll have to see about this organization, since if the matrices are a separate prop from cameraState it doesn’t make as much sense to group them with the cameraState stories…but they are camera-related, so maybe it’s fine. You might find some opportunities to clean up the organization while you’re there.

Looking forward to your branch!

0reactions
janpaul123commented, Apr 9, 2020

Cool, feel free to make a PR if you think it’s stable enough now. 😄

Read more comments on GitHub >

github_iconTop Results From Across the Web

3D Reconstruction of Plant/Tree Canopy Using Monocular ...
[27] developed a novel method to recover camera matrices and 3D points from unordered images. All these technologies were known as Structure from...
Read more >
webviz from cruise-automation - Coder Social
feature request : `cameraMatrices` prop in `<Worldview />` component. Awesome library, thanks for all you do!. I'd like to supply my own camera...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found