Automatic Rules PeriodicArchiver should not use HTTP requests to self

        // FIXME using an HTTP request to localhost here works well enough, but is needlessly
        // complex. The API handler targeted here should be refactored to extract the logic that
        // creates the recording from the logic that simply figures out the recording parameters
        // from the POST form, path param, and headers. Then the handler should consume the API
        // exposed by this refactored chunk, and this refactored chunk can also be consumed here
        // rather than firing HTTP requests to ourselves

[andrewazores]

I think what’s happening there is that you’re created an object called spy, which wraps around the archiver instance, and has your customized behaviour (throw an exception when performArchival is called), but this doesn’t actually change the behaviour of archiver - only spy.

If the archiver is modified so that run/performArchival no longer use webClient but instead use targetConnectionManager instead, then you would modify the targetConnectionManager spy/mock so that it throws an exception when some method that run/performArchival calls is called.

[andrewazores]

You could probably put it into RecordingCreationHelper and just rename that class to something a little more general.