Issue with creodias provider

Describe the bug When using eodag + creodias provider, the search works, but the download fails inconsistently (at different % of completition for the same file). When finishing (extract: false set in the config), the filename is changed from .SAFE.zip to .SAFE and the product is incomplete and not usable.

Code To Reproduce

eodag -vvv download --conf /tmp/creodias.conf --search-results /tmp/SLC.geojson

Output 1st try:

2021-07-08 14:10:01,901-15s eodag.config                     [INFO    ] (config           ) Loading user configuration from: /tmp/creodias.conf
2021-07-08 14:10:02,581-15s eodag.core                       [DEBUG   ] (core             ) Opening product types index in /root/.config/eodag/.index
2021-07-08 14:10:02,582-15s eodag.core                       [INFO    ] (core             ) Downloading 1 products
Downloading products:   0%|                                                                                                                                      | 0/1 [00:00<?, ?product/s]2021-07-08 14:10:03,005-15s eodag.plugins.download.http      [INFO    ] (http             ) Download url: https://zipper.creodias.eu/download/55cbdcca-aaa9-5fd2-aef3-36d5596bcaa1
 77%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████▌                                   | 2.18G/2.82G [29:56<05:08Downloading products: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [36:04<00:00, 2164.8Downloading products: 100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [36:04<00:00, 2164.82s/product]
Traceback (most recent call last):
  File "/opt/eod/venv/bin/eodag", line 8, in <module>
    sys.exit(eodag())
  File "/opt/eod/venv/lib/python3.8/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/opt/eod/venv/lib/python3.8/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/opt/eod/venv/lib/python3.8/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/eod/venv/lib/python3.8/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/eod/venv/lib/python3.8/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/opt/eod/venv/lib/python3.8/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/opt/eod/venv/lib/python3.8/site-packages/eodag/cli.py", line 412, in download
    downloaded_files, downloaded_files_json = satim_api.download_all(search_results)
TypeError: cannot unpack non-iterable NoneType object

2nd try:

eodag -vvv download --conf /tmp/creodias.conf --search-results /tmp/SLC.geojson
2021-07-08 14:10:01,901-15s eodag.config                     [INFO    ] (config           ) Loading user configuration from: /tmp/creodias.conf
2021-07-08 14:10:02,581-15s eodag.core                       [DEBUG   ] (core             ) Opening product types index in /root/.config/eodag/.index
2021-07-08 14:10:02,582-15s eodag.core                       [INFO    ] (core             ) Downloading 1 products
Downloading products:   0%|                                                                                                                                      | 0/1 [00:00<?, ?product/s]2021-07-08 14:10:03,005-15s eodag.plugins.download.http      [INFO    ] (http             ) Download url: https://zipper.creodias.eu/download/55cbdcca-aaa9-5fd2-aef3-36d5596bcaa1
                                                                                                                                                                                           2021-07-08 14:40:10,699-15s eodag.plugins.download.http      [DEBUG   ] (http             ) Download recorded in /mnt/cache/.downloaded/3261f94003115d5abdec56d1ed67898030:07<23:31, 681kB/s]
2021-07-08 14:40:10,962-15s eodag.plugins.download.http      [WARNING ] (http             ) Downloaded product is not a Zip File. Please check its file type before using it
Downloading products: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [30:08<00:00, 1808.38s/product]
Traceback (most recent call last):
  File "/opt/eod/venv/bin/eodag", line 8, in <module>
    sys.exit(eodag())
  File "/opt/eod/venv/lib/python3.8/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/opt/eod/venv/lib/python3.8/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/opt/eod/venv/lib/python3.8/site-packages/click/core.py", line 1137, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/eod/venv/lib/python3.8/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/eod/venv/lib/python3.8/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/opt/eod/venv/lib/python3.8/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/opt/eod/venv/lib/python3.8/site-packages/eodag/cli.py", line 412, in download
    downloaded_files, downloaded_files_json = satim_api.download_all(search_results)
TypeError: cannot unpack non-iterable NoneType object
 66%|████████████████████████████████████████████████████████████████████████████████████████████████▏                                                 | 1.86G/2.82G [30:07<15:37, 1.03MB/s]

Environment:

• Python version: python 3.8.10

Additional context Add any other context about the bug here.

[remi-braun]

Here they are 😄

S2A_MSIL2A_20210509T103021_N0300_R108_T32TLT_20210509T133016.SAFE
S2A_MSIL2A_20210618T103021_N0300_R108_T32TLT_20210618T133547.SAFE
S2A_MSIL2A_20210728T103031_N0301_R108_T32TLT_20210728T152601.SAFE
S2A_MSIL2A_20210906T103021_N0301_R108_T32TLT_20210906T151711.SAFE
S2A_MSIL2A_20211016T103031_N0301_R108_T32TLT_20211016T133750.SAFE
S2A_MSIL2A_20211125T103351_N0301_R108_T32TLT_20211125T133031.SAFE
S2B_MSIL2A_20220109T103319_N0301_R108_T32TLT_20220109T121931.SAFE
S2A_MSIL2A_20191226T103431_N0213_R108_T32TLT_20191226T120024.SAFE
S2A_MSIL2A_20190808T103031_N0213_R108_T32TLT_20190808T140801.SAFE
S2A_MSIL2A_20190828T103021_N0213_R108_T32TLT_20190828T164154.SAFE
S2A_MSIL2A_20190917T103021_N0213_R108_T32TLT_20190917T141750.SAFE
S2A_MSIL2A_20191007T103021_N0213_R108_T32TLT_20191007T131042.SAFE
S2A_MSIL2A_20191027T103131_N0213_R108_T32TLT_20191027T120218.SAFE
S2A_MSIL2A_20191116T103311_N0213_R108_T32TLT_20191116T115132.SAFE
S2A_MSIL2A_20191206T103421_N0213_R108_T32TLT_20191206T121006.SAFE

[sbrunato]

@remi-braun if you have some products ids for which you have issues, can you please post them to help us reproduce the error ? Thanks