question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`extractAllToAsync` callback need to wait for the writing to finish

See original GitHub issue

v0.5.6

zip.extractAllToAsync(output, true, err => {
  /* istanbul ignore if */
  if (err != null) throw err
  resolve()
})

ref: https://github.com/cthackers/adm-zip/blob/3caa15d50b54d19a2212a11b5a6c86d89caa4a77/adm-zip.js#L668

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:4
  • Comments:5

github_iconTop GitHub Comments

4reactions
dscalzicommented, Oct 15, 2021

I’m pretty sure this changing is causing the callback to never trigger now. An operation that was working now hangs indefinitely.

Read more comments on GitHub >

github_iconTop Results From Across the Web

node.js - Nodejs extract zip ansynchronously - Stack Overflow
I'm currently using adm-zip to extract a zip file to a certain path but its extractAllTo method is synchronous. Is there a way...
Read more >
Callbacks in JavaScript | Zell Liew
Asynchronous here means that, if JavaScript needs to wait for something to complete, it will execute the rest of the tasks given to...
Read more >
https://raw.githubusercontent.com/obsproject/crowd...
isDebug = isDebug; /** * Writes debug message to user log * @param message ... we need to finish reading the response before...
Read more >
[jira] [Commented] (CB-13056) Remove non platform-API ...
+# Unless required by applicable law or agreed to in writing, ... Default is FALSE - * @param callback - */ - extractAllToAsync...
Read more >
Callback Functions in JavaScript Simply Explained for ...
Now, let's write a function for pulling data from the API. Since this function has an API call, it can take a while...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found