Computed properties execute even if they are not currently being accessed.

Hi @ctrlplusb,

We ran into an issue with computed properties. It seems like computed properties which are currently not being accessed also execute which cause all sorts of weird problems.

Here is a simple example:

const userModel = {
  data: {},
  withBlocked: computed(
    [state => state.data],
    user => {
      // computed body
    },
  ),
  withFriends: computed(
    [state => state.data],
    user => {
      // computed body
    },
  ),
  authorize: action((state, payload) => {
    state.data = payload;
  }),
  unauthorize: action(state => (state.data = {})),
};

now somewhere else when we execute:

const actions = store.getActions();
actions.user.unauthorize();

both withBlocked and withFriends will be fired even though they are not used anywhere.

This maybe related to https://github.com/ctrlplusb/easy-peasy/issues/446

I started to look at the source code and I think the issue could be related to: https://github.com/ctrlplusb/easy-peasy/blob/master/src/create-reducer.js#L48

Although this probably requires a bigger refactor in order to track which computed props are currently utilized.

[ctrlplusb]

Thanks for the feedback both. I am investigating. 👍

[ctrlplusb]

Hi @mkuklis

I have already tracked this down. ☺️

A fix is in the works. It has to do with the way immer is working. I will be pushing a patch onto the 3.4.0 alpha branch soonish and will ping you to ask you to test it. 👍