question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Issue with Immer polyfills after upgrading to version 4.0.1

See original GitHub issue

First off: 👏 for the good work on the new release! I think I just had to change one line (in a test) after the upgrade for everything to be working 👏

However, I’ve got a tiny issues with supporting older browser. I’ve done as explained here, to enableES5() for Immer - but it does not seem to be enough, as I still get an error (IE11):

image

The issue referred to, is 20: "Cannot use proxies if Proxy, Proxy.revocable or Reflect are not available".

Am I missing something, or is this an issue “upstream”?

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:8 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
jmyrlandcommented, Oct 19, 2020

I’ve added a little PR for testing 1. above: #575

(I’m unable to add any reviewers though)

1reaction
jmyrlandcommented, Oct 19, 2020

Okay, it is working now. I just had to add immer as an explicit dependency to the “app” as well.

Our polyfills are loaded via a “shared” package (which had immer as a dependency). However, this did not work, unless Immer is installed for the app as well 🤷‍♀️

I’m thinking of 2 ways to potentially prevent further issues:

  1. Expose a polyfill for easy-peasy, i.e. import "easy-peasy/polyfill" (By doing this, I don’t think Immer is required as an explicit dependency)
  2. If an explicit dependency is required - it should be added as a peer-dependency for easy-peasy

I’m hoping that 1. resolves this, so the immer dependency can be handled by easy-peasy.

Whats your thoughts?

Read more comments on GitHub >

github_iconTop Results From Across the Web

react-dev-utils uses a vulnerable version of immer as ... - GitHub
We are still getting this issue ever after upgrading to 11.0.2 in our project. Immer dependency is still at 7.0.9. Request the author...
Read more >
reactjs - "Critical Prototype Pollution in immer" Patched >=9.0.6
My main issue was my significant gap in knowledge on how package versions work and are supposed to be upgraded. It was very...
Read more >
react-scripts | Yarn - Package Manager
Important: This documentation covers modern versions of Yarn. For 1.x docs, see classic.yarnpkg.com. Yarn.
Read more >
Create React App: CHANGELOG-4.x.md | Fossies
We've upgraded to ESLint 7 and added many new rules including some for Jest and React Testing Library as well as the import/no-anonymous-default-export...
Read more >
invalid options object. dev server has been initialized - You.com
But then when I did the same I came across a problem, when I tried to do npm ... is using webpack-dev-server version...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found