question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

hooks should not require public visibility -- at least should log an error/warning

See original GitHub issue

Is your feature request related to a problem? Please describe. I was frustrated when i tried to figure out why my tests would fail. Until i notices that my setup was not public. From the old days in junit i know that they used to require that too, but no more and nowadays it’s so common to have all that test stuff with package visibility (to avoid cluttering autocompletion in IDEs i guess) I just did it here too w/o even giving it a 2nd though.

So now my code looks like so to make my team mates (we are all new CC) aware of the fact.

   @Before //method must be public!! otherwise it's silently ignored!
    public void setUp() {
        msUniteTestHarness.reset();
    }

Describe the solution you’d like Also allow package visibility but by all means don’t just silently drop the execution

Describe alternatives you’ve considered Throwing an error would be OK too but behavior is not anymore in alignment with junit.

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:14 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
mpkorstanjecommented, Sep 1, 2021

Step definitions and hooks that would previously be ignored would now be discovered. Even though this may not have been intentional, it would change an existing setup.

0reactions
mpkorstanjecommented, Nov 4, 2021

We would still have to scan the super class. Just to let users know they made a mistake.

JUnit for example does allow inheritance -it makes sense there- and that assumption is carried over to Cucumber where it does not make sense.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Git push error pre-receive hook declined - Stack Overflow
It looks like there's a very popular answer that must work for most people. In my case, however, the same message was received...
Read more >
Project and group visibility - GitLab Docs
By default, /public is visible to unauthenticated users. However, if the Public visibility level is restricted, /public is visible only to signed-in users....
Read more >
View - Android Developers
You do not need to override all of these methods. In fact, you can start by just overriding onDraw(android.graphics.Canvas) .
Read more >
Advisory Circular - Federal Aviation Administration
The markings on a runway may be upgraded to include elements that are not required. For example, side stripes, touchdown zone markings, etc.,...
Read more >
Using Lambda with Amazon SQS - AWS Documentation
Use a Lambda function to process messages from an Amazon SQS queue. ... For this reason, your function code must be able to...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found