No tests are discovered if feature starts with comments followed by description

👓 What did you see?

It seems that (at least) the junit-platform-suite fails to discover tests if any feature starts with a comment followed by a description

✅ What did you expect to see?

Tests should be discovered since syntax is correct

📦 Which tool/library version are you using?

Cucumber for java 7.8.1

🔬 How could we reproduce it?

Steps to reproduce the behavior:

1. A feature which starts with a comment followed by a description

Feature: Feature 2
  # some comment
  some description

  Scenario: Scenario 1
    * Wait 3s

1. Run feature, either from Maven or from the IDE. You may also try to execute the whole suite of tests containing this Feature. No test will be executed.
2. See error from maven surefire plugin:

[ERROR] There was an error in the forked process
[ERROR] TestEngine with ID 'junit-platform-suite' failed to discover tests
[ERROR] org.apache.maven.surefire.booter.SurefireBooterForkException: There was an error in the forked process
[ERROR] TestEngine with ID 'junit-platform-suite' failed to discover tests
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:701)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:311)
[ERROR]         at org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:268)
[ERROR]         at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1334)
[ERROR]         at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1167)

You can reproduce this issue by building the following cucumber-showcase project: https://github.com/fslev/cucumber-showcase.git

mvn clean test

[mpkorstanje]

Gherkin has a grammar that explicitly includes comments and comments are not allowed before the description.

https://github.com/cucumber/common/blob/main/gherkin/gherkin.berp#L37

DescriptionHelper := #Empty* Description? #Comment*

You may want to create an issue in https://github.com/cucumber/common to address that.

[mpkorstanje]

Yeah, that’s between JUnit 5 and Surefire. You could petition the JUnit 5 team to include more information in the JUnitException thrown when discovery fails.