question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add support for CancelToken?

See original GitHub issue

Hey,

Its probably too early to begin this in earnest but assuming most wants to play well in the spec-compliant world then would it make sense to add support for CancelTokens (detail) in any special way?

While cancelToken.promise is sufficient to feed combinators like until I wonder if anything special needs to be done on the error handling side to distinguish between a canceled stream versus a failed one.

Issue Analytics

  • State:closed
  • Created 7 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
TylorScommented, Dec 13, 2016

I can’t speak for the other contributors, but I can say I’m not too interested in becoming spec-compliant. If we were to become spec-compliant, we would almost certainly see a performance drop.

0reactions
briancavaliercommented, Dec 18, 2016

No worries, @jasonkuhrt. Yeah, I think the withdraw was surprising to most folks. I haven’t seen a good explanation for the reasons other than “google objected”. I wasn’t personally a fan of the proposal, but it’d be nice to know the reasons.

Read more comments on GitHub >

github_iconTop Results From Across the Web

[Feature Request] Add support for CancellationToken #1239
Add a CancellationToken property in TokenAcquisitionOptions and, if available use it in TokenAcquisition in calls to: AcquireTokenXXX methods ...
Read more >
Cancellation | Axios Docs
Starting from v0.22.0 Axios supports AbortController to cancel requests in fetch ... You can create a cancel token using the CancelToken.source factory as ......
Read more >
CancellationToken Struct (System.Threading) | Microsoft Learn
A CancellationToken enables cooperative cancellation between threads, thread pool work items, or Task objects. You create a cancellation token by instantiating ...
Read more >
What is cancelToken by axios and how I fix it? - Stack Overflow
My 2cents: looks like it's easier NOT to make the request in the first place, if user is not authorized =) Just add...
Read more >
Axios Cancel Request - Mastering JS
Axios supports a limited mechanism for cancelling requests. The syntax is straightforward: you pass a cancelToken option to your Axios ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found