until/takeUntil with predicate function

The until/takeUntil function accepts an input stream, however I was wondering if we could add support for a predicate function? This is different from takeWhile because it is inclusive of the first item to return false.

For inspiration, have a look at the API for RxJava which has similar options (stream or predicate) for its takeUntil operator: http://reactivex.io/RxJava/javadoc/rx/Observable.html#takeUntil(rx.functions.Func1)

[briancavalier]

Hey @OliverJAsh, we just released 1.3.0 with skipAfter. Check it out, and let us know if it works for you.

[briancavalier]

I kinda like the name skipAfter. It reads fairly nicely in prose: “skip all the events after ‘Fred’”, and in code: events.skipAfter(x => x === 'Fred').

Trying to think of a name using “take” that describes this operation, without using the word “until” is tricky!

I think takeUntil, or anything using “until” with a predicate could be confusing, because it doesn’t necessarily have a strong indication of whether it’s inclusive or exclusive (that concern is also expressed in the RxJava thread). “When” has a similar problem, imho. I think the word “after” has a more clear connotation. “After” has a time connotation, which could lead someone to believe it’s like until or since, but “while” has the same issue. Maybe then it’s helpful if we stick with “until” and “since” as time vocabulary, and “while” and “after” as predicate vocabulary?

Other ideas?

cc @davidchase @TylorS