Changing subscriptions

I noticed in both grapher-react and the grapher guide, that you create new subscriptions without unsubscribing to the old ones. Even though the subscription handle on the query is overwritten, the old subscription remains active! This is what I do in my Vue helper:

let oldSub = _.clone(query.subscriptionHandle)
query.subscribe()
oldSub && oldSub.stop()

(If you unsubscribe before you subscribe, you lose any data that the old and new subscriptions may have shared, causing flickering).

Maybe query.subscribe() should automatically do this if a subscription already exists?

[theodorDiaconu]

@Herteby if you use grapher-react, it uses createContainer(), and inside it it subscribes, createContainer auto unsubscribes anything inside it when it’s unmounted.

[theodorDiaconu]

This process is handled by createContainer, they automatically destroy subscriptions when component is unmounted.