Possible bug: Duplicate cache of same doc if updated inside Collection.after.insert

Hi,

I’m using the matb33:collection-hookspackage.

It provides hooks like Collection.after.insert.

Suppose I have Questions collection denormalized into Lectures collection.

When I create a question “What’s up?”, the expected behaviour is for Lecture document to look like this:

// Lecture Document
_id: ....
questionsCache: [
  {
    _id: 5e44dRMouE9BiwgLP,
   body: "What's up?"
  }
]

However, suppose I have a after.insert hook in which I update that question, like this:

Questions.after.insert((userId, doc) => {
  Questions.update({_id: doc._id}, {$set: {someFlag: true}});
})

When this is the case, this is what questionsCache looks like instead:

// Lecture Document
_id: ....
questionsCache: [
  {
    _id: 5e44dRMouE9BiwgLP,
   body: "What's up?"
  },
  {
    _id: 5e44dRMouE9BiwgLP,
   body: "What's up?",
   someFlag: true
  },
]

Is there perhaps a race condition going on, because the after.insert hook probably fires before the cache is registered?

[Herteby]

Hi! Grapher uses my denormalization package, which is actually built on Collection Hooks too. The order in which Collection Hooks run is determined by the order they were set up. You could try swapping the order you create the denormalization and set up your insert hook, or you could use my cacheField function, which is tested to work properly with the other cache types.

[nadeemja]

Cool. I’ll try 😃