Setting overridePublishFunction to false still publishes via Redis

In Meteor 1.5.1 in redis-oplog 1.2.6, 1.2.6_1, and 1.2.6_2, whenever I set overridePublishFunction: false, I’m still seeing all of my app’s Meteor.publish(...) calls getting published with Redis.

I can see it in the debug output of redis-oplog and the publications are visually/functionally reactive in my app.

I was adding some special functionality with Vent, which is really cool BTW, and needed to add redis-oplog but I don’t want any of my publications (or app in general) to use redis-oplog (for now) except my Vent code. So I set overridePublishFunction: false, yet it’s still using redis-oplog. I do still have pushToRedis: true but I assumed this would be ignored if I have overridePublishFunction: false and use all Meteor.publish(...) calls.

I can make a repo but it’s pretty easy to reproduce. I created two Meteor apps from my redis-oplog-issues repo, set overridePublishFunction: false on both, made the second app point to the first app’s database and ran it on port 3002. Then when you click add twenty tasks, check one off to create a Scorecard, then click “Toggle Scorecards” it updates instantly in both apps via Redis because the Meteor.publish(...) calls are using Redis.

[theodorDiaconu]

The reason is because of this: extendMongoCollection(); which overrides the .observeChanges() and .observe(). We either create observeChangesWithRedis() observeWithRedis() functions, either not execute those functions, either separate redis-vent into a separate package, which is a natural thing to do, but then we need to separate redis-connection to a package, so both redis-oplog and redis-vent can use it. I’ll think about this in 1.3

[evolross]

Just for conversation purposes… one reason it would be useful to use Vent without redis-oplog is if you make use of a micro-service structure (which I do in my app).

So I may have a particular micro-service that needs to listen for Vent emissions but doesn’t need to use redis-oplog for pub-sub.

To make use of Vent now, I have to upgrade all my micro-services to redis-oplog - which is probably a good thing. But not all of them are overwhelmed by oplog-tailing.