Proper DOM cleanup while driver disposal

This problem is actual for such use cases as hot-reload of cycle app, or then cycle apps are pereodically instantiated while runtime.

In such scenarios when don’t need running app anymore we dispose all sinks and sources, then probably cleanup HTML and replace with with new instance.

The problem is that while DOM driver disposal vdom tree is not cleaned up and thus destroy hooks on elements (widgets) do not work, this may cause some leaks and side effects.

To address this issue I curretly use use this as a solution:

const _makeDOMDriver = (contaner, options) =>
  (dom$) => {
    let empty$ = new BehaviorSubject()
    empty$.onNext(false)
    let source = makeDOMDriver(contaner, options)(
      Observable.combineLatest(dom$, empty$, (dom, empty) => {
        return empty ? div('') /* empty dom */ : dom}
      )
    )
    let _dispose = source.dispose
    source.dispose = () => {
      empty$.onNext(true)
      _dispose.apply(source)
    }
    return source
  }

I wonder if something like this (vdom cleanup) should be done by DOM driver by default while disposal.

[wclr]

@Frikki https://github.com/cyclejs/dom/pull/128 you may look in to this, it was almost implemented, but not finished.

[Frikki]

@whitecolor No, they don’t. I have been attempting to implement the suggestions with the latest releases, but to little avail. Hence, my request.

UPDATE: I am so sorry. Forget it. The library wasn’t compiling automatically when I ran the browser tests.