Hardcoded timeout limit for dotnet command leads to problems with debugging

Steps to reproduce:

1. See that sometimes cyclonedx-dotnet returns Dotnet restore failed: and so can’t make result bom file
2. In same case when run it pair with dotnet restore command everything is ok

Current result: dotnet restore is called inside cyclonedx-dotnet in DotnetUtilsService.cs

        public DotnetUtilsResult Restore(string path)
        {
            var arguments = "restore";
            if (!string.IsNullOrEmpty(path)) arguments = $"{arguments} \"{path}\"";

            var commandResult = _dotnetCommandService.Run(arguments);

            if (commandResult.Success)
            {
                return new DotnetUtilsResult();
            }
            else
            {
                return new DotnetUtilsResult
                {
                    // dotnet restore only outputs to std out, not std err
                    ErrorMessage = commandResult.StdOut
                };
            }
        }

If look on dotnetCommandService.Run

public DotnetCommandResult Run(string workingDirectory, string arguments)
        {
            var psi = new ProcessStartInfo(DotNetExe.FullPathOrDefault(), arguments)
            {
                CreateNoWindow = true,
                RedirectStandardOutput = true,
                RedirectStandardError = true,
                UseShellExecute = false,
                WorkingDirectory = workingDirectory
            };
            
            using (var p = Process.Start(psi))
            {
                var exitCode = 0;
                // ...
                var processExited = p.WaitForExit(60000);
                if (processExited)
                {
                    exitCode = p.ExitCode;
                }
                else
                {
                    p.Kill();
                    exitCode = -1;
                }
                // ...
                return result;
            }

Here we see hard-limit for 60 sec to call dotnet restore. It could be not enough in some cases, e.g. when you need to download 400+ heavyweight dependencies

Expected result:

1. Add option for cyclonedx-dotnet to change this time limit
2. Add error message to output about the limit passing event

[coderpatros]

@oxdef closing this issue. It isn’t released yet. But will be in the next release.

[oxdef]

@coderpatros Thanks for the quick fix!