Performance Optimization Discussion

Issue type:

• 🐌 Performance issue

---

Short description:

Continuing conversation from #1147. When Having large networks, performance degrades. I found some places where optimizations can be made using this performance profile

Potential Optimizations

The below were brought to my attention from the profile linked above since they were taking a significant amount of time to process/execute.

1. org.cyclops.integrateddynamics.core.part.aspect.build.AspectBuilder lines 418 and 420 can be run in parallel since there doesn’t seem to be any order requirements in each onUpdate method.

2. org.cyclops.integrateddynamics.core.network.Network line 441 same recommendation as 1.

3. org.cyclops.integrateddynamics.core.network.IngredientChannelAdapterWrapperSlotted lines 52 and 55 Setting the position state to disabled then re-enabled in the same context seems unnecessary since those changes can only happen on the main thread in series anyway.

4. org.cyclops.integrateddynamics.core.network.IngredientChannelAdapterWrapperSlotted lines 69 and 72 same recommendation as 3.

[rubensworks]

Thanks for reporting!

[rubensworks]

No worries @Geo25rey, I wasn’t trying to rush you 😃

I do want to a little more investigation on my end, especially regarding the hashCode methods being used. (And anything else I can find)

👌

Also, I noticed that you had an idea for an in-game performance monitor. Is there a way I can help with that?

Certainly! I think these issues have a high priority, but I don’t think I’ll have time for them in the near future:

• https://github.com/CyclopsMC/IntegratedDynamics/issues/863
• https://github.com/CyclopsMC/IntegratedDynamics/issues/1156