Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Need to add a timeout to wait_on command

See original GitHub issue

v1.26.0

Without a timeout, the wait_on waits for the default 10 minute timeout before failing without any output. If the server is exiting right away, this means 10 minute CI run just to fail. I think we could set the timeout of 1 minute and it would be enough.

Issue Analytics

State:
Created 3 years ago
Comments:7 (3 by maintainers)

Top GitHub Comments

1reaction

bahmutovcommented, Oct 29, 2020

Sure these are two different ways of doing it

Sent from my iPhone

On Oct 29, 2020, at 11:44, Henrik Feldt notifications@github.com wrote:

I guess I’m saying that wasting 10 minutes x all the instances using this “orb”, is a huge waste, when IRL it might crash after 5 seconds: so it’s better not to use a separate step, and instead call through some process manager.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

1reaction

hafcommented, Oct 29, 2020

It should not be a timeout; if the concurrent process crashes, wait-on should terminate immediately.