question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

cypress-cli type for CypressRunResult::runs is incorrect (can be null/undefined)

See original GitHub issue

Current behavior:

In the event that the browser fails to connect, the run promise resolves with results which has runs of null or undefined. (Which is likely a separate issue altogether. It should probably not resolve at all - it should reject).

However, the typings indicate that the type of runs is RunResult[] which doesn’t match null

Desired behavior:

The type should indicate that runs can be undefined or null, or run() should not resolve on an error running the tests altogether.

Test code to reproduce

  1. Clone https://github.com/xdumaine/cypress-test-tiny
  2. npm i && npm test

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:5 (2 by maintainers)

github_iconTop GitHub Comments

1reaction
xdumainecommented, Mar 3, 2020

@jennifer-shehane my PR is ready for final review…

0reactions
cypress-bot[bot]commented, Apr 20, 2020

Released in 4.4.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to Cypress v4.4.1, please open a new issue.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Command Line - Cypress Documentation
Commands. cypress run. Runs Cypress tests to completion. By default, cypress run will run all tests headlessly.
Read more >
BrowserStack-Cypress CLI reference
List of all the CLI commands and args you can use to run tests, stop the ones that are running, and retrieve build...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found