Cypress update instructions given say to update with npm, even if you're using yarn

Current behavior:

When I open Cypress and there’s a new update, the update instructions tell me to use npm install --save-dev cypress@3.1.2 rather than saying yarn add --dev cypress@3.1.2.

Desired behavior:

If a yarn.lock file is detected instead of a package-lock.json file, the message should given you the yarn instructions.

The location of the update code is found at:

• packages/desktop-gui/src/update/update-banner.jsx

The location of the code that tests the update banner:

• integration/update_banner_spec.coffee

Steps to reproduce:

I assume you should be able install Cypress 3.1.1, run it with ``cypress open` and see the update button / with instructions.

Versions

• 3.1.1

Operating System

Windows 10

[chrisbreiding]

The desktop-gui package is similar to a web app in a browser and doesn’t have access to the user’s file system. For that, it utilizes the server package.

For the update check, the desktop-gui sends an updater:check message, which is received here in the server and calls into Updater.check here. One possible solution is to check for the existence of yarn.lock in Updater.check and return with an isYarn: true|false property along with the new version.

Honestly, it might be better to just show both options in the dialog instead of trying to determine if the user is using yarn:

To update Cypress:

1. Quit this app

2. If using npm, run `npm install --save-dev cypress@3.1.5`
   
   If using yarn, run `yarn add cypress@3.1.5`

3. Run ...

[jennifer-shehane]

This issue will be closed to further comment as the exact issue here was resolved and tested.

If you’re experiencing a bug similar to this in Cypress, please open a new issue with a fully reproducible example that we can run. There may be a specific edge case with the issue that we need more detail to fix.