Cypress will not stop test run if errors in before hook

• Operating System: osx
• Cypress Version: 2.0.2
• Browser Version: Canary 66

Is this a Feature or Bug?

Bug

Current behavior:

If an error is raised in the before hook for tests, Cypress will not stop the test run and seems to continue indefinitely.

This behaviour seems identical to #674

Desired behavior:

Tests should fail with a descriptive error message.

How to reproduce:

Run the below code

Test code:

describe('Demo throw in before hook', () => {
  before(() => {
    cy.exec('echo "test test"').then(() => {
      throw new Error('whoa something broke');
    });
  });

  it('visits url', () => {
    cy.get('/');
  });
  // NB: for some reason if I comment out the below test
  // Cypress UI will fail the test correctly.
  it('gets element', () => {
    cy.get('.someelem');
  });
});

Additional Info (images, stack traces, etc)

Below is a screenshot that shows that although the error is thrown, the spinner still continues to… spin 😃

[probablyup]

FWIW I’m seeing this in “run” mode as well as a result of a page timeout during before. The screenshot gets written but the process never exits.

[brian-mann]

This PR should fix this. Thank you for opening a good issue.