Make grepFilterSpecs work when specPattern has been set in the config

The grepFilterSpecs only appears to work correctly if the specPattern value is the default value. If the value is changed, by setting it within the config, the grepFilterSpecs no longer works.

example of config:

const { defineConfig } = require('cypress');

module.exports = defineConfig({
    e2e: {
        setupNodeEvents(on, config) {
            require('cypress-grep/src/plugin')(config);
            return config;
        },
        baseUrl: 'http://localhost:802/',
        specPattern: 'tests/cypress/e2e/**',
        supportFile: 'tests/cypress/support/e2e.js',
        env: {
            grepFilterSpecs: true,
            grepOmitFiltered: true,
        },
    },
});

With specPattern in config: Specs: 54 found

Without specPattern in config: Specs: 17 found

[bahmutov]

To speed up solving this issue a small repo showing the problem is 200x useful

[joshuajtward]

Yeah good point @s4ms00n9, grepIntegrationFolder is a bit of an artefact from when I was doing the upgrade to work with 10.0.0, I initially wrote it to be backward compatible with 9.0.0, but I was persuaded to make it a breaking change to gently push people to upgrade. I think that’s why I forgot to add any info to the README about it 🤦‍♂️

For this issue going forward, I think grepIntegrationFolder should probably be renamed to something like relativeConfigFileToIntegrationFolderPath (or use path to resolve two paths for us), and I should add something to the docs for it. @jablesyeah does setting it to be the relative path for your setup work? (not as a solution, but to validate that we’re on the right track)

In addition, I’ve just seen this: cypress-io/cypress-grep#153, so we should probably move this issue to the main Cypress repo, as cypress-grep excitingly now lives here: https://github.com/cypress-io/cypress/tree/develop/npm/grep